Add tracker health check client #378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-Kalpakchiev
force-pushed
the
tracker-health-client
branch
from
b5627eb
to
4801c88
Compare
Anton-Kalpakchiev
force-pushed
the
tracker-health-client
branch
from
4801c88
to
2d3c637
Compare
gkeesh7
reviewed
Nov 14, 2024
| @@ -89,6 +92,18 @@ func getEndpoint(version int, addr string, h core.InfoHash) (method, url string) | |||
| return "POST", fmt.Sprintf("http://%s/announce/%s", addr, h.String()) | |||
| } | |||
|
|
|||
| func (c *client) CheckHealth() error { | |||
| addr := c.ring.Locations(backend.ReadinessCheckDigest)[0] | |||
There was a problem hiding this comment.
Sanity check to see if the ring Locations is not empty.
locations := c.ring.Locations(backend.ReadinessCheckDigest)
if len(locations) == 0 {
return fmt.Errorf("no locations available for health check")
}
addr := locations[0]
gkeesh7
reviewed
Nov 14, 2024
| addr := c.ring.Locations(backend.ReadinessCheckDigest)[0] | ||
| _, err := httputil.Get( | ||
| fmt.Sprintf("http://%s/health", addr), | ||
| httputil.SendTimeout(2*time.Second), |
There was a problem hiding this comment.
making this configurable would be a nice to have.
gkeesh7
reviewed
Nov 14, 2024
Anton-Kalpakchiev
force-pushed
the
build-index-is-ready
branch
from
ab090d4
to
1386190
Compare
|
Turns out that the tracker's readiness is not equal to its health. The tracker must check the origin's readiness. Thus a client for the health endpoint is not required. Instead a readiness endpoint will be implemented in #380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #371, all services should implement a "readiness" endpoint, which checks whether the service is ready to serve traffic, i.e. whether it can reach all of its dependencies. The agent's readiness endpoint will check whether it has any healthy trackers available (as it needs to query a tracker to get data about where a torrent can be found). Thus, the agent needs a client for the tracker's health endpoint.
Add health check client endpoint for tracker, which queries its health endpoint.
Stacked on top of #377